• Top
    • Documentation
    • Books
    • Boolean-reasoning
    • Projects
    • Debugging
    • Std
    • Proof-automation
    • Macro-libraries
    • ACL2
    • Interfacing-tools
    • Hardware-verification
      • Gl
      • Esim
      • Vl2014
      • Sv
      • Fgl
      • Vwsim
      • Vl
        • Syntax
        • Loader
        • Warnings
        • Getting-started
        • Utilities
        • Printer
        • Kit
          • Vl-lint
            • Vl-lintconfig-p
            • Condcheck
            • Lint-warning-suppression
            • Lucid
            • Lvaluecheck
            • Vl-interfacelist-alwaysstyle
            • Truncation-warnings
            • Vl-modulelist-alwaysstyle
            • Skip-detection
            • Vl-lint-report
            • Vl-lintresult
            • Vl::vl-design-sv-use-set
            • Oddexpr-check
            • Leftright-check
              • Vl-packagelist-leftright-check
              • Vl-modulelist-leftright-check
              • Vl-interfacelist-leftright-check
              • Vl-collect-ac-args
              • Vl-leftright-exprlist-duplicates
              • Vl-interface-leftright-check
              • Vl-package-leftright-check
              • Vl-module-leftright-check
              • Vl-expr-leftright-check1
              • Vl-expr-leftright-check
              • Vl-expr-indexy-via-ctx
              • Vl-ctxexprlist-leftright-check
              • Vl-design-leftright-check
              • Vl-ctxexprlist-leftright-check-nrev
              • Vl-op-ac-p
            • Duplicate-detect
            • Selfassigns
            • *vl-lint-help*
            • Arith-compare-check
            • Dupeinst-check
            • Qmarksize-check
            • Lint-whole-file-suppression
            • Run-vl-lint-main
            • Logicassign
            • Run-vl-lint
            • Vl-print-certain-warnings
            • Duperhs-check
            • Vl-lint-top
            • Sd-filter-problems
            • Vl-modulelist-add-svbad-warnings
            • Vl-module-add-svbad-warnings
            • Check-case
            • Vl-lint-extra-actions
            • Drop-lint-stubs
            • Vl-lint-print-warnings
            • Drop-user-submodules
            • Check-namespace
            • Vl-lintconfig-loadconfig
            • Vl-lint-design->svex-modalist-wrapper
            • Vl-delete-sd-problems-for-modnames-aux
            • Vl-collect-new-names-from-orignames
            • Vl-lint-print-all-warnings
            • Vl-design-remove-unnecessary-modules
            • Vl-delete-sd-problems-for-modnames
            • Vl-always-check-style
            • Vl-vardecllist-svbad-warnings
            • Vl-vardecl-svbad-warnings
            • Vl-reportcard-remove-suppressed
            • Vl-reportcard-keep-suppressed
            • Vl-alwayslist-check-style
            • Vl-remove-nameless-descriptions
            • Vl-lint-apply-quiet
            • Vl-warninglist-remove-suppressed
            • Vl-warninglist-keep-suppressed
            • Vl-print-eliminated-descs
            • Vl-module-alwaysstyle
            • Vl-jp-reportcard-aux
            • Vl-interface-alwaysstyle
            • Vl-design-alwaysstyle
            • Vl-jp-description-locations
            • Vl-jp-reportcard
            • Vl-pp-stringlist-lines
            • Vl-jp-design-locations
            • Vl-datatype-svbad-p
            • Unpacked-range-check
            • Sd-problem-major-p
            • Vl-alwaysstyle
          • Vl-server
          • Vl-gather
          • Vl-zip
          • Vl-main
          • Split-plusargs
          • Vl-shell
          • Vl-json
        • Mlib
        • Transforms
      • X86isa
      • Svl
      • Rtl
    • Software-verification
    • Math
    • Testing-utilities
  • Vl-lint

Leftright-check

Check for strange expressions like A [op] A.

This is a heuristic for generating warnings, inspired by PVS Studio. It has found a few pretty minor things that we were able to clean up, and also found one interesting copy/paste bug.

We look for identical sub-expressions on the left and right of most binary operations, for instance A | A and A == A. It is usually pretty strange to write such an expression, and sometimes these indicate copy/paste errors. We do similar checking for the then- and else-branches of ?: operators.

We also look for part-selects that use the same expressions for both indices, e.g., foo[3:3], but these are somewhat more common and minor, and sometimes result from macros or parameterized modules, so we generally think these are pretty minor and uninteresting.

Subtopics

Vl-packagelist-leftright-check
(vl-packagelist-leftright-check x ss) maps vl-package-leftright-check across a list.
Vl-modulelist-leftright-check
(vl-modulelist-leftright-check x ss) maps vl-module-leftright-check across a list.
Vl-interfacelist-leftright-check
(vl-interfacelist-leftright-check x ss) maps vl-interface-leftright-check across a list.
Vl-collect-ac-args
Collect the nested arguments to an associative/commutative operator.
Vl-leftright-exprlist-duplicates
Optimized duplicate expression gatherer for leftright checking.
Vl-interface-leftright-check
Vl-package-leftright-check
Vl-module-leftright-check
Vl-expr-leftright-check1
Search for strange expressions like A [op] A.
Vl-expr-leftright-check
Vl-expr-indexy-via-ctx
Vl-ctxexprlist-leftright-check
Vl-design-leftright-check
Vl-ctxexprlist-leftright-check-nrev
Vl-op-ac-p
Recognizes the associative/commutative binary vl-op-ps.